Bug 54640

Summary:

[Chromium] media/video-display-toggle.html fails (IMAGE) on all platforms

Product:

WebKit

Reporter:

Mikhail Naganov <mnaganov>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annacc, commit-queue, mihaip

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch	none

Mikhail Naganov

Reported 2011-02-17 05:10:16 PST

See logs (search for media/video-display-toggle.html): http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5/builds/1315/steps/webkit_tests/logs/stdio http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/2468/steps/webkit_tests/logs/stdio http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/1607/steps/webkit_tests/logs/stdio This test was already marked as failing, but missed a bugzilla issue.

Attachments
Patch (2.29 KB, patch) 2011-02-22 13:03 PST, Anna Cavender	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anna Cavender

Comment 1 2011-02-22 11:27:41 PST

This test assumes that when the "playing" event fires, the controls will change from the "play" glyph to the "pause" glyph. This may or may not be the case as the drawing of the controls happens asynchronously. I propose a change that acts on "canplaythrough" (when the video is loaded and ready) and then seeks to a frame (so that the pixel diff is guaranteed) after toggling the display. Patch coming shortly.

Anna Cavender

Comment 2 2011-02-22 13:03:40 PST

Created attachment 83372 [details] Patch

WebKit Commit Bot

Comment 3 2011-02-23 00:27:54 PST

Comment on attachment 83372 [details] Patch Clearing flags on attachment: 83372 Committed r79415: <http://trac.webkit.org/changeset/79415>

WebKit Commit Bot

Comment 4 2011-02-23 00:27:59 PST

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 5 2011-02-23 00:52:12 PST

The commit-queue encountered the following flaky tests while processing attachment 83372 [details]: http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.

Note You need to log in before you can comment on or make changes to this bug.