Bug 54621

Summary: [EFL] Remove proxy feature of soup when proxy is null
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, leandro, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
tonikitoo: review+, tonikitoo: commit-queue-
Fixed Patch
tonikitoo: review+
Fixed Patch
gyuyoung.kim: commit-queue+
Fixed Patch none

Gyuyoung Kim
Reported 2011-02-17 00:36:47 PST
In void ewk_settings_proxy_uri_set(const char* proxy), it is better to remove proxy feature when parameter is NULL.
Attachments
Patch (1.48 KB, patch)
2011-02-17 00:41 PST, Gyuyoung Kim 		tonikitoo: review+
tonikitoo: commit-queue-
DetailsFormatted DiffDiff
Fixed Patch (1.50 KB, patch)
2011-02-17 15:21 PST, Gyuyoung Kim 		tonikitoo: review+
DetailsFormatted DiffDiff
Fixed Patch (1.32 KB, patch)
2011-02-17 20:23 PST, Gyuyoung Kim 		gyuyoung.kim: commit-queue+
DetailsFormatted DiffDiff
Fixed Patch (1.32 KB, patch)
2011-02-17 20:25 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-02-17 00:41:54 PST
Created attachment 82763 [details] Patch
Antonio Gomes
Comment 2 2011-02-17 05:55:38 PST
Comment on attachment 82763 [details] Patch Please move "session" declaration line to withing the "if" block.
Gyuyoung Kim
Comment 3 2011-02-17 15:21:48 PST
Created attachment 82869 [details] Fixed Patch >> Please move "session" declaration line to withing the "if" block. Do you mean that the session declaration need to be moved to if block ? I add "return" to if block. How do you think about it ? The session declaration should be declared regardless of proxy.
Antonio Gomes
Comment 4 2011-02-17 20:15:16 PST
Comment on attachment 82869 [details] Fixed Patch In "removes proxy feature in soup." it should be "remove".
Gyuyoung Kim
Comment 5 2011-02-17 20:23:04 PST
Created attachment 82909 [details] Fixed Patch I fix the wrong spelling. Thank you for your review.
Gyuyoung Kim
Comment 6 2011-02-17 20:25:29 PST
Created attachment 82910 [details] Fixed Patch I add your name to reviewer field in Changelog. Thank you.
WebKit Commit Bot
Comment 7 2011-02-18 19:20:55 PST
Comment on attachment 82910 [details] Fixed Patch Clearing flags on attachment: 82910 Committed r79070: <http://trac.webkit.org/changeset/79070>
Note You need to log in before you can comment on or make changes to this bug.