Bug 54605

Summary: http/tests/security/cross-frame-access-child-explicit-domain.html is flaky due to built-in timeouts
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: Tools / TestsAssignee: Peter Kasting <pkasting>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch v1 none

Peter Kasting
Reported 2011-02-16 18:23:18 PST
http/tests/security/cross-frame-access-child-explicit-domain.html is flaky on the Chromium Win Debug bot (see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20-%20chromium.org&tests=http%2Ftests%2Fsecurity%2Fcross-frame-access-child-explicit-domain.html ). This is because the test internally puts setTimeout(..., 2000) blocks around attempts to load frames. This is a recipe for flakiness. Test harnesses can kill long-running tests anyway, so it seems like we'd do better to just eliminate these timeouts entirely.
Attachments
patch v1 (3.96 KB, patch)
2011-02-17 14:04 PST, Peter Kasting 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Kasting
Comment 1 2011-02-17 14:04:32 PST
Created attachment 82859 [details] patch v1
James Robinson
Comment 2 2011-02-17 14:17:26 PST
The patch had the wrong mimetype and didn't have the "patch" bit set - did you use webkit-patch to upload?
James Robinson
Comment 3 2011-02-17 14:17:53 PST
Comment on attachment 82859 [details] patch v1 R=me
Peter Kasting
Comment 4 2011-02-17 14:20:02 PST
(In reply to comment #2) > The patch had the wrong mimetype and didn't have the "patch" bit set - did you use webkit-patch to upload? Oops, sorry, forgot to toggle that. (I uploaded manually.)
WebKit Commit Bot
Comment 5 2011-02-18 19:02:43 PST
The commit-queue encountered the following flaky tests while processing attachment 82859 [details]: media/invalid-media-url-crash.html bug 51138 (author: inferno@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-02-18 19:04:42 PST
Comment on attachment 82859 [details] patch v1 Clearing flags on attachment: 82859 Committed r79066: <http://trac.webkit.org/changeset/79066>
WebKit Commit Bot
Comment 7 2011-02-18 19:04:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.