Bug 54596

Summary:

new-run-webkit-tests: enable multiple processes by default on mac

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, atwilson, dglazkov, eric, mihaip, morrita, ojan, pkasting, rniwa, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	jamesr: review+

Dirk Pranke

Reported 2011-02-16 15:36:49 PST

new-run-webkit-tests: enable multiple processes by default on mac

Attachments
Patch (1.84 KB, patch) 2011-02-16 15:37 PST, Dirk Pranke	no flags	Details Formatted Diff Diff
Patch (8.53 KB, patch) 2011-02-18 18:13 PST, Dirk Pranke	jamesr: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2011-02-16 15:37:11 PST

Created attachment 82712 [details] Patch

Ojan Vafai

Comment 2 2011-02-17 00:01:45 PST

Comment on attachment 82712 [details] Patch Fingers crossed!

Dirk Pranke

Comment 3 2011-02-18 15:53:47 PST

Committed r79047: <http://trac.webkit.org/changeset/79047>

Andrew Wilson

Comment 4 2011-02-18 17:16:02 PST

Reverted r79047 for reason: Broke canary bots - please watch the canaries the next time you land this Committed r79055: <http://trac.webkit.org/changeset/79055>

Dirk Pranke

Comment 5 2011-02-18 17:46:01 PST

Whoops. I didn't handle the Leopard/Python 2.5 "multiprocessing isn't available" case properly, unfortunately. Sorry about the canary miss ... I was at a presentation.

Dirk Pranke

Comment 6 2011-02-18 18:13:08 PST

Created attachment 83042 [details] Patch

Dimitri Glazkov (Google)

Comment 7 2011-02-18 18:15:49 PST

So exciting!

Dirk Pranke

Comment 8 2011-02-18 18:18:49 PST

Committed r79062: <http://trac.webkit.org/changeset/79062>

Ryosuke Niwa

Comment 9 2011-02-21 06:18:45 PST

It seems like some http tests have been failing on Chromium since this patch is landed: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=http%2Ftests%2Floading%2Flocation-hash-reload-cycle.html%2Chttp%2Ftests%2Fnavigation%2Fimage-load-in-unload-handler.html%2Chttp%2Ftests%2Fnavigation%2Fping-cookie.html%2Chttp%2Ftests%2Fnavigation%2Fping-same-origin.html%2Chttp%2Ftests%2Fsecurity%2FisolatedWorld%2Fall-window-properties.html%2Chttp%2Ftests%2Fsecurity%2FisolatedWorld%2Fall-window-prototypes.html

Dirk Pranke

Comment 10 2011-02-21 13:27:33 PST

investigating ...

Dirk Pranke

Comment 11 2011-02-21 18:03:05 PST

(In reply to comment #10) > investigating ... rniwa filed chromium bug http://crbug.com/73651 . I would prefer to triage the http failures there and leave this bug alone for now ...

Note You need to log in before you can comment on or make changes to this bug.