Bug 54584

Summary:

Summary: HTML5 <details> and <summary>: HTMLSummaryElement

Product:

WebKit

Reporter:

Luiz Agostini <luiz>

Component:

Layout and Rendering

Assignee:

Luiz Agostini <luiz>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

51071

Attachments:

Description	Flags
patch	tkent: review-
patch	none
patch	kling: review+

Luiz Agostini

Reported 2011-02-16 13:57:41 PST

Adding class HTMLSummaryElement to build systems.

Attachments
patch (14.62 KB, patch) 2011-02-16 14:07 PST, Luiz Agostini	tkent: review-	Details Formatted Diff Diff
patch (14.63 KB, patch) 2011-02-17 08:07 PST, Luiz Agostini	no flags	Details Formatted Diff Diff
patch (14.77 KB, patch) 2011-02-17 08:15 PST, Luiz Agostini	kling: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Luiz Agostini

Comment 1 2011-02-16 14:07:12 PST

Created attachment 82690 [details] patch

WebKit Review Bot

Comment 2 2011-02-16 14:09:20 PST

Attachment 82690 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/html/HTMLSummaryElement.cpp:21: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/html/HTMLSummaryElement.cpp:22: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/html/HTMLSummaryElement.h:30: The parameter name "document" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 3 2011-02-16 14:18:28 PST

Attachment 82690 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7927332

Kent Tamura

Comment 4 2011-02-17 06:38:13 PST

Comment on attachment 82690 [details] patch Why HTMLSummaryElement.{cpp,h} are needed? ChangeLog should explain it. Please fix style errors.

Luiz Agostini

Comment 5 2011-02-17 08:07:09 PST

Created attachment 82809 [details] patch

Luiz Agostini

Comment 6 2011-02-17 08:15:50 PST

Created attachment 82811 [details] patch