Summary: | Summary: HTML5 <details> and <summary>: HTMLSummaryElement | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luiz Agostini <luiz> | ||||||||
Component: | Layout and Rendering | Assignee: | Luiz Agostini <luiz> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, tkent, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 51071 | ||||||||||
Attachments: |
|
Description
Luiz Agostini
2011-02-16 13:57:41 PST
Created attachment 82690 [details]
patch
Attachment 82690 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/html/HTMLSummaryElement.cpp:21: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Source/WebCore/html/HTMLSummaryElement.cpp:22: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Source/WebCore/html/HTMLSummaryElement.h:30: The parameter name "document" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 3 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 82690 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7927332 Comment on attachment 82690 [details]
patch
Why HTMLSummaryElement.{cpp,h} are needed? ChangeLog should explain it.
Please fix style errors.
Created attachment 82809 [details]
patch
Created attachment 82811 [details]
patch
Latest patch just adds some explanations to ChangeLog. Committed r78914: <http://trac.webkit.org/changeset/78914> |