Bug 54565

Summary: syncSoftwareCanvas with SKIA_GPU enabled should only make context current
Product: WebKit Reporter: Brian Salomon <bsalomon>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bsalomon, commit-queue, kbr, reed, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch to make syncSoftwareCanvas call makeContextCurrent none

Brian Salomon
Reported 2011-02-16 09:57:21 PST
Currently PlatformContext::syncSoftwareCanvas binds an FBO externally to Skia's gpu backend. This confuses the backend because resetContext() is not called. Moreover, the skia backend can bind the correct FBO itself when it is invoked to draw. We really just need to make the GC3D context current before drawing through Skia.
Attachments
patch to make syncSoftwareCanvas call makeContextCurrent (1.22 KB, patch)
2011-02-16 10:00 PST, Brian Salomon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Salomon
Comment 1 2011-02-16 10:00:12 PST
Created attachment 82657 [details] patch to make syncSoftwareCanvas call makeContextCurrent
Brian Salomon
Comment 2 2011-02-16 10:13:18 PST
Adding Vangelis, Ken, and Mike to cc.
Vangelis Kokkevis
Comment 3 2011-02-16 13:25:03 PST
This looks good although I think we won't have a complete solution until bug# 54327 is fixed.
WebKit Commit Bot
Comment 4 2011-02-16 17:11:03 PST
Comment on attachment 82657 [details] patch to make syncSoftwareCanvas call makeContextCurrent Clearing flags on attachment: 82657 Committed r78754: <http://trac.webkit.org/changeset/78754>
WebKit Commit Bot
Comment 5 2011-02-16 17:11:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.