Bug 54558

Summary: Web Inspector: split all the functions of Inspector backend API by domain.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[patch] initial version
none
[patch] second version
yurys: review-
[patch] third version none

Description Ilya Tikhonovsky 2011-02-16 08:08:34 PST 
We have a number of functions from different domains in single InspectorBackend instance.
I'd be better to split the functions by domain.
As example 'evaluate' will be moved from InspectorBackend to InspectorBackend.Runtime container.
Comment 1 Ilya Tikhonovsky 2011-02-16 08:12:58 PST 
Created attachment 82641 [details]
[patch] initial version
Comment 2 Ilya Tikhonovsky 2011-02-16 09:02:35 PST 
Created attachment 82650 [details]
[patch] second version

In this version all the functions are accessible via a conainer for their domain.
original: InspectorBackend.evaluate("lalala");
new version: RuntimeAgent.evaluate("lalala");
Comment 3 Yury Semikhatsky 2011-02-16 09:07:31 PST 
Comment on attachment 82650 [details]
[patch] second version

View in context: https://bugs.webkit.org/attachment.cgi?id=82650&action=review

> LayoutTests/ChangeLog:9
> +        I'd be better to split the functions by their domains.

I'd -> It'd

> Source/WebCore/inspector/CodeGeneratorInspector.pm:628
> +            window[agentName] = [];

window[agentName] should be Object not Array. r- for this.
Comment 4 Ilya Tikhonovsky 2011-02-16 09:13:43 PST 
Created attachment 82651 [details]
[patch] third version

comments addressed
Comment 5 Ilya Tikhonovsky 2011-02-16 09:18:16 PST 
Comment on attachment 82651 [details]
[patch] third version

Clearing flags on attachment: 82651

Committed r78717: <http://trac.webkit.org/changeset/78717>
Comment 6 Ilya Tikhonovsky 2011-02-16 09:18:28 PST 
All reviewed patches have been landed.  Closing bug.