Bug 54554 – REGRESSION(r78678): Breaks NaCl tests in Chromium (Requested by mnaganov on #webkit).

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

http://trac.webkit.org/changeset/78678 broke the build:
Breaks NaCl tests in Chromium (Requested by mnaganov on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 82629 [details]
ROLLOUT of r78678

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Mikhail Naganov]

Manually committed http://trac.webkit.org/changeset/78705

[Mikhail Naganov]

Ah, I'm sorry for not providing you this info at the first hand.
Two tests were failing (crashing):
  - NaClUITest.PPAPIHelloWorld from nacl_ui_test.cc
  - NaClSandboxTest.NaClOuterSBTest from nacl_sandbox_test.cc

And this was easily reproducible on my Linux machine -- I was able to bisect the roll to find out that this was because of your change.

[David Levin]

Comment on attachment 82629 [details]
ROLLOUT of r78678

Cleared cq? as this was already landed.

[Bill Budge]

Mikhail,

I am trying to set breakpoints on the changed code to see why this simple change causes a crash. They never get hit, so I suspect I'm not attached to the right process. Are there any tips you can give me for how to attach (in Visual Studio right now) after the process is created but before too much code gets run?

(In reply to comment #3)
> Ah, I'm sorry for not providing you this info at the first hand.
> Two tests were failing (crashing):
>   - NaClUITest.PPAPIHelloWorld from nacl_ui_test.cc
>   - NaClSandboxTest.NaClOuterSBTest from nacl_sandbox_test.cc
> 
> And this was easily reproducible on my Linux machine -- I was able to bisect the roll to find out that this was because of your change.

[Mikhail Naganov]

Hi Bill,

Take a look at this page: http://dev.chromium.org/developers/how-tos/debugging
I used '--renderer-startup-dialog --no-sandbox' flags to get renderer process to stop and show me its PID before it does anything important. You might need to modify the code that starts Chromium from the test.