Summary: | [Gtk] Add support for layoutTestController.setWillSendRequestClearHeader | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sergio Villar Senin
2011-02-16 01:30:54 PST
Created attachment 82604 [details]
Patch
I know ChangeLogs are not OK. I used webkit-path upload to upload the patch and didn't realize that I had to edit both. I guess I should change them before committing Comment on attachment 82604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82604&action=review Great stuff. Please consider the following changes befor committing. > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:95 > + GHashTable* headersHash = g_hash_table_new(g_str_hash, g_str_equal); I think I'd rather this be a Vector<String> or a HashMap<String, int>. You're already converting to String below so you can just reuse that. That will allow you to remove a few lines below. > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1015 > +static void willSendRequestCallback(WebKitWebView* webView, WebKitWebFrame*, WebKitWebResource* resource, WebKitNetworkRequest* request, WebKitNetworkResponse* redirectResponse) You can remove the "resource' and "redirectResponse" paramter names. Committed r78718: <http://trac.webkit.org/changeset/78718> http://trac.webkit.org/changeset/78718 might have broken Qt Linux Release The following tests are not passing: media/controls-without-preload.html |