Bug 54520

Summary: test-webkitpy doesn't work with the multiprocessing module on win32
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, dpranke, eric, mihaip, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 48728    
Attachments:
Description Flags
Patch
none
revise, disable run_webkit_tests_unittest processes tests none

Dirk Pranke
Reported 2011-02-15 19:18:03 PST
In order to work within the restrictions of the multiprocessing module under win32, the main python file of a running python script needs to be importable (i.e., it needs to end in .py and be found in sys.path). See new-run-webkit-tests for a workaround.
Attachments
Patch (1.57 KB, patch)
2011-02-17 17:02 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
revise, disable run_webkit_tests_unittest processes tests (2.85 KB, patch)
2011-02-17 17:09 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-02-17 17:02:14 PST
Created attachment 82878 [details] Patch
Dirk Pranke
Comment 2 2011-02-17 17:09:50 PST
Created attachment 82879 [details] revise, disable run_webkit_tests_unittest processes tests
Dirk Pranke
Comment 3 2011-02-17 17:28:26 PST
*** Bug 54651 has been marked as a duplicate of this bug. ***
Adam Roben (:aroben)
Comment 4 2011-02-17 17:52:19 PST
Comment on attachment 82879 [details] revise, disable run_webkit_tests_unittest processes tests View in context: https://bugs.webkit.org/attachment.cgi?id=82879&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:229 > +# FIXME: https://bugs.webkit.org/show_bug.cgi?id=54520. > +if multiprocessing and sys.platform not in ('cygwin', 'win32'): A little more explanation would be nice here.
Dirk Pranke
Comment 5 2011-02-17 20:29:22 PST
Comment on attachment 82879 [details] revise, disable run_webkit_tests_unittest processes tests Clearing flags on attachment: 82879 Committed r78944: <http://trac.webkit.org/changeset/78944>
Dirk Pranke
Comment 6 2011-02-17 20:29:25 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2011-02-18 01:24:39 PST
http://trac.webkit.org/changeset/78944 might have broken GTK Linux 32-bit Debug
Note You need to log in before you can comment on or make changes to this bug.