Bug 54502

Summary: media/audio-delete-while-slider-thumb-clicked.html failing on Windows since r78562
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, pnormand
Priority: P2 Keywords: LayoutTestFailure, PlatformOnly, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
proposed patch aroben: review+

Steve Falkenburg
Reported 2011-02-15 15:26:58 PST
media/audio-delete-while-slider-thumb-clicked.html failing on Windows since r78562. Change http://trac.webkit.org/changeset/78562 refactored the test to use oncanplaythrough. This caused the test to fail on Windows.
Attachments
proposed patch (1.72 KB, patch)
2011-02-16 03:05 PST, Philippe Normand 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2011-02-15 15:34:36 PST
Failure message: CONSOLE MESSAGE: line 38: TypeError: 'null' is not an object (evaluating 'audio.parentNode')
Adam Roben (:aroben)
Comment 2 2011-02-15 15:53:51 PST
We normally check in Windows-specific expected failing results in cases like this where the test fails the same way every time and isn't crashing or timing out. That way we can notice when the behavior of the test changes (e.g., if someone fixes it).
Philippe Normand
Comment 3 2011-02-16 03:05:16 PST
Created attachment 82607 [details] proposed patch
Philippe Normand
Comment 4 2011-02-16 03:06:43 PST
Can someone on Windows please try this patch? I think the seeking event was triggered twice so the test tried to delete the audio element twice, leading to that "undefined" error.
Adam Roben (:aroben)
Comment 5 2011-02-16 05:00:21 PST
Comment on attachment 82607 [details] proposed patch This fixes the test on Windows for me. Please remove the test from LayoutTests/platform/win/Skipped, too.
Philippe Normand
Comment 6 2011-02-16 05:55:02 PST
Committed r78701: <http://trac.webkit.org/changeset/78701>
Note You need to log in before you can comment on or make changes to this bug.