Bug 54436 – controls are rendered below canvas in mediaDocument instead of overlapping

• Component: Media
• Status: RESOLVED FIXED

[Ami Fischman]

This is a continuation of the saga of bug 27798 wherein a partial overlap was incorrectly fixed by removing all the overlap, instead of making the overlap complete (as it is in non-mediaDocument pages).

[Ami Fischman]

Created attachment 82416 [details]
Patch

[David Levin]

Comment on attachment 82416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82416&action=review

> Source/WebCore/ChangeLog:15
> +        expected spot (0,208) instead of below the canvas (0,240).  Any

This part about "any" doesn't belong in the ChangeLog but would be fine in the bug.

> Source/WebCore/ChangeLog:18
> +        output but not on a PNG?)

Not that I know of. I know that you can dump markup but I don't think that would suit your needs.

btw, I strongly suspect that these results are chromium specific. So LayoutTests/media/video-controls-in-media-document-expected.txt may not be the best place for them.

[Ami Fischman]

Created attachment 82496 [details]
Patch

[Ami Fischman]

Removed this from the ChangeLog:
     Any suggestions for minimizing the assertion would be gratefully
     accepted (in particular, is it possible to assert on the render
     tree text output but not on a PNG?)

Can you give me a hint about how to generate expectations for other platforms?  AFAICT the mac bots don't take patches from non-committers (e.g. "Error: mac-ews cannot process patches from non-committers :(") and of course until I submit this the continuous builders won't be building this (new) test).

[Ami Fischman]

Created attachment 82510 [details]
Patch

[Ami Fischman]

Moved expectations to platform/chromium per IM convo w/ levin@.

[David Levin]

(In reply to comment #4)
> Removed this from the ChangeLog:
>      Any suggestions for minimizing the assertion would be gratefully
>      accepted (in particular, is it possible to assert on the render
>      tree text output but not on a PNG?)
> 
> Can you give me a hint about how to generate expectations for other platforms?  AFAICT the mac bots don't take patches from non-committers (e.g. "Error: mac-ews cannot process patches from non-committers :(") and of course until I submit this the continuous builders won't be building this (new) test).

fwiw the ews bots don't run layout tests anyway at this point/

[WebKit Commit Bot]

Comment on attachment 82510 [details]
Patch

Rejecting attachment 82510 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'build-..." exit_code: 2

Last 500 characters of output:
websocket/tests/workers ......
http/tests/workers ......
http/tests/xhtmlmp .
http/tests/xmlhttprequest ...............................................................................................................................................................................
http/tests/xmlhttprequest/web-apps ...............
http/tests/xmlhttprequest/workers .........
666.53s total testing time

22618 test cases (99%) succeeded
1 test case (<1%) was new
15 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/7920097

[Ami Fischman]

Created attachment 82583 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 82583 [details]
Patch

Clearing flags on attachment: 82583

Committed r78680: <http://trac.webkit.org/changeset/78680>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jessie Berlin]

Did you plan on landing any expected results for this new test?

http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r79006%20(9501)/results.html

[Ami Fischman]

(In reply to comment #12)
> Did you plan on landing any expected results for this new test? 
> http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r79006%20(9501)/results.html

I was planning to skip it until I could find rebaselines on other platforms, but missed win (got mac).  Working on it now.

[Ami Fischman]

jberlin adding to win Skipped list to make bot green.
https://bugs.webkit.org/show_bug.cgi?id=54757 filed to baseline on mac & win.