Bug 5443

Summary: REGRESSION highlight left behind when contracting a selection
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
compute highlight width correctly darin: review+

mitz
Reported 2005-10-20 09:03:55 PDT
The selection highlight is not repainted correctly when contracting the selection by dragging its end. To reproduce: drag across a line of text on this page from left to right and all the way back, starting the selection anywhere *after* the first character. I think this also comes from the latest changes to WebTextRenderer.m (r1.198 or r1.197). Looks like the editing/selection/fake-drag pixel-test detects this regression.
Attachments
compute highlight width correctly (1.22 KB, patch)
2005-10-20 09:46 PDT, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2005-10-20 09:46:17 PDT
Created attachment 4422 [details] compute highlight width correctly This patch also fixes the regression where the drag image for selections that don't start at character 0 was incorrect.
Darin Adler
Comment 2 2005-10-20 14:16:40 PDT
Comment on attachment 4422 [details] compute highlight width correctly Oops! Thanks. Sorry.
Note You need to log in before you can comment on or make changes to this bug.