Summary: | r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Kasting <pkasting> | ||||
Component: | Text | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, koivisto, mario, psolanki | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 53898 | ||||||
Attachments: |
|
Description
Peter Kasting
2011-02-14 15:45:21 PST
It's also causing crashes in SnowLeopard and GTK bots. See full backtrace as got from the GTK 32-bit debug bot in my last comment in bug 53898: https://bugs.webkit.org/show_bug.cgi?id=53898#c56 Created attachment 82431 [details]
check for zero
Comment on attachment 82431 [details]
check for zero
r=me
Comment on attachment 82431 [details]
check for zero
Hmm, no this is not correct. It should still flush the partial sequence and set the error flag. Better leave it for Darin.
Comment on attachment 82431 [details]
check for zero
re-r+ing again as agreed on IRC.
I don't see a problem with this patch, TextCodecUTF16 has the same check.
http://trac.webkit.org/changeset/78541 I also filed https://bugs.webkit.org/show_bug.cgi?id=54444 Correct handling of end of buffer partial sequence in UFT8 decoder when flushing with zero length |