Bug 54400

Summary:

Need WebKit API to determine whether we have a site icon for a given URL

Product:

WebKit

Reporter:

Brian Weinstein <bweinstein>

Component:

WebKit API

Assignee:

Brian Weinstein <bweinstein>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, aroben, beidson, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
[PATCH] Fix	beidson: review+, beidson: commit-queue-

Brian Weinstein

Reported 2011-02-14 10:15:26 PST

We need WebKit API to determine whether we have a site icon for a given URL. This will return true if we do, false if we will use the default icon.

Attachments
[PATCH] Fix (3.70 KB, patch) 2011-02-14 10:24 PST, Brian Weinstein	beidson: review+ beidson: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brian Weinstein

Comment 1 2011-02-14 10:24:47 PST

Created attachment 82331 [details] [PATCH] Fix

Brady Eidson

Comment 2 2011-02-14 11:20:07 PST

Comment on attachment 82331 [details] [PATCH] Fix Can you add a space to the current newline instead of adding a new newline?

Brian Weinstein

Comment 3 2011-02-14 11:28:04 PST

(In reply to comment #2) > (From update of attachment 82331 [details]) > Can you add a space to the current newline instead of adding a new newline? The file already had an extra newline, so I was able to delete it instead of adding a new one. Thanks for the review!

WebKit Review Bot

Comment 4 2011-02-14 14:57:59 PST

http://trac.webkit.org/changeset/78498 might have broken GTK Linux 64-bit Debug

Brian Weinstein

Comment 5 2011-02-14 15:20:47 PST

Landed in r78498.

Note You need to log in before you can comment on or make changes to this bug.