Bug 54394

Summary: [GTK] Bump GTK+3 dependency to 3.0
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported 2011-02-14 08:15:22 PST
Now that GTK+ has been released we should bump the dependency to 3.0. Maybe we should make it the default option now, falling back to gtk+2 when gtk+3 is not present.
Attachments
Patch (1.03 KB, patch)
2011-02-14 08:18 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-02-14 08:18:34 PST
Created attachment 82318 [details] Patch
Martin Robinson
Comment 2 2011-02-17 15:22:33 PST
This seems reasonable. I'd like to get Xan or Gustavo's approval as well though.
Xan Lopez
Comment 3 2011-02-17 15:38:03 PST
I think making the dependency reflect the minimum version we actually need to compile makes sense, so I don't see any reason to do this.
Carlos Garcia Campos
Comment 4 2011-02-18 09:42:34 PST
(In reply to comment #3) > I think making the dependency reflect the minimum version we actually need to compile makes sense, so I don't see any reason to do this. Library name has changed, you won't be using gtk+ 3.0.x unless you bump the dependency to 3.0, I don't think we want to use 2.99.x.
Xan Lopez
Comment 5 2011-02-18 09:59:35 PST
(In reply to comment #4) > Library name has changed, you won't be using gtk+ 3.0.x unless you bump the dependency to 3.0, I don't think we want to use 2.99.x. I didn't know they had changed them *again* for 3.0. You should have mentioned it in the bug report, neither me or Martin were aware of this. r=me then.
Carlos Garcia Campos
Comment 6 2011-02-20 01:22:28 PST
Committed r79150: <http://trac.webkit.org/changeset/79150>
Carlos Garcia Campos
Comment 7 2011-02-20 01:25:03 PST
(In reply to comment #5) > (In reply to comment #4) > > Library name has changed, you won't be using gtk+ 3.0.x unless you bump the dependency to 3.0, I don't think we want to use 2.99.x. > > I didn't know they had changed them *again* for 3.0. You should have mentioned it in the bug report, neither me or Martin were aware of this. r=me then. Ok, sorry, I thought that depending on an stable version was enough reason to bump requirements. Pushed now.
Note You need to log in before you can comment on or make changes to this bug.