Bug 54369
| Summary: | Turn on -Woverloaded-virtual for GCC builds of JSC | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Cameron Zwarich (cpst) <zwarich> |
| Component: | JavaScriptCore | Assignee: | Cameron Zwarich (cpst) <zwarich> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | andersca, simon.fraser, zwarich |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Cameron Zwarich (cpst)
Thanks to bug 53760, JSC builds with -Woverloaded-virtual using Clang. It should also build this way with GCC. If it does, we should enable the warning.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Cameron Zwarich (cpst)
Actually, this warning is really broken in Apple's GCC. It requires derived classes to overload all base class signatures if they overload any of them.
Cameron Zwarich (cpst)
I don't think we'll ever do this.