Bug 54351

Summary: Unnecessary call to containingBlock() in RenderBoxModelObject::relativePositionOffsetX()
Product: WebKit Reporter: Leo Yang <leo.yang.c>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch - fixed typo none

Leo Yang
Reported 2011-02-13 01:16:50 PST
We don't need to call containningBlock() twice in RenderBoxModelObject::relativePositionOffsetX().
Attachments
Patch (2.50 KB, patch)
2011-02-13 01:31 PST, Leo Yang 		no flags
DetailsFormatted DiffDiff
Patch - fixed typo (2.50 KB, patch)
2011-02-13 04:10 PST, Leo Yang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2011-02-13 01:31:51 PST
Created attachment 82254 [details] Patch
Andreas Kling
Comment 2 2011-02-13 03:51:15 PST
Comment on attachment 82254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82254&action=review r=me > Source/WebCore/ChangeLog:5 > + Unnecessary call of containningBlock() in RenderBoxModelObject::relativePositionOffsetX() Typo, containingBlock()
Leo Yang
Comment 3 2011-02-13 04:10:23 PST
Created attachment 82257 [details] Patch - fixed typo
WebKit Commit Bot
Comment 4 2011-02-13 11:31:54 PST
The commit-queue encountered the following flaky tests while processing attachment 82257 [details]: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2011-02-13 11:33:33 PST
Comment on attachment 82257 [details] Patch - fixed typo Clearing flags on attachment: 82257 Committed r78437: <http://trac.webkit.org/changeset/78437>
Note You need to log in before you can comment on or make changes to this bug.