Bug 54321

Summary: [chromium] Allow turning off multisampling through web reference settings
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch kbr: review+

Description Zhenyao Mo 2011-02-11 15:43:04 PST 
So later we could hook up chromium side through a command line flag "--disable-gl-multisampling".

Note that I also have the chromium side CL ready for review.  I tested that with patches on both side, "--disable-gl-multisampling" will turn off multisampling in WebGL in chromium.
Comment 1 Zhenyao Mo 2011-02-11 15:53:27 PST 
Created attachment 82203 [details]
Patch
Comment 2 Kenneth Russell 2011-02-11 18:09:18 PST 
Comment on attachment 82203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82203&action=review

Basically looks fine with a couple of nits. Appreciate your fixing upon commit.

> Source/WebCore/ChangeLog:5
> +        [chromium] Allow turning off multisampling through web reference settings

reference -> preference

> Source/WebCore/ChangeLog:10
> +        * page/Settings.cpp: Add a fflag for multisampling preference.

typo: fflag

> Source/WebCore/ChangeLog:14
> +        (WebCore::Settings::setGLMultisamplingEnabled):
> +        * page/Settings.h: Ditto.
> +        (WebCore::Settings::GLMultisamplingEnabled):

These don't match WebKit capitalization conventions. I'd suggest "setOpenGLMultisamplingEnabled" / "openGLMultisamplingEnabled".

> Source/WebKit/chromium/ChangeLog:5
> +        [chromium] Allow turning off multisampling through web reference settings

again, reference -> preference
Comment 3 Zhenyao Mo 2011-02-12 12:46:59 PST 
Committed r78419: <http://trac.webkit.org/changeset/78419>