Bug 54310

Summary:

Enable ArrayBuffers by default

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cmarrin, dglazkov, dpranke, eric, jberlin, kbr, pkasting, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
patch for win-ews to chew on	none
patch for win-ews to chew on	none
patch for win-ews to chew on	none
patch for win-ews to chew on	none

Adam Barth

Reported 2011-02-11 13:54:45 PST

Enable ArrayBuffers by default

Attachments
Patch (29.82 KB, patch) 2011-02-11 13:56 PST, Adam Barth	no flags	Details Formatted Diff Diff
Patch (31.76 KB, patch) 2011-02-11 14:08 PST, Adam Barth	no flags	Details Formatted Diff Diff
patch for win-ews to chew on (35.38 KB, patch) 2011-02-11 18:43 PST, Adam Barth	no flags	Details Formatted Diff Diff
patch for win-ews to chew on (37.06 KB, patch) 2011-02-11 20:28 PST, Adam Barth	no flags	Details Formatted Diff Diff
patch for win-ews to chew on (37.75 KB, patch) 2011-02-11 21:38 PST, Adam Barth	no flags	Details Formatted Diff Diff
patch for win-ews to chew on (38.32 KB, patch) 2011-02-11 23:17 PST, Adam Barth	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2011-02-11 13:56:46 PST

Created attachment 82170 [details] Patch

Eric Seidel (no email)

Comment 2 2011-02-11 13:59:15 PST

Comment on attachment 82170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82170&action=review > Source/WebCore/page/DOMWindow.idl:508 > + attribute [JSCCustomGetter] ArrayBufferConstructor ArrayBuffer; // Usable with new operator Why JSCCustomGetters?

Peter Kasting

Comment 3 2011-02-11 14:02:08 PST

Should http://trac.webkit.org/changeset/78337 also get reverted in this patch?

Adam Barth

Comment 4 2011-02-11 14:03:20 PST

(In reply to comment #2) > (From update of attachment 82170 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82170&action=review > > > Source/WebCore/page/DOMWindow.idl:508 > > + attribute [JSCCustomGetter] ArrayBufferConstructor ArrayBuffer; // Usable with new operator > > Why JSCCustomGetters? Dunno. That's just what was there. We can investigate in a follow up patch. (In reply to comment #3) > Should http://trac.webkit.org/changeset/78337 also get reverted in this patch? Probably.

WebKit Review Bot

Comment 5 2011-02-11 14:04:39 PST

Attachment 82170 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7870769

Adam Barth

Comment 6 2011-02-11 14:08:54 PST

Created attachment 82173 [details] Patch

Build Bot

Comment 7 2011-02-11 15:15:27 PST

Attachment 82173 [details] did not build on win: Build output: http://queues.webkit.org/results/7869766

Kenneth Russell

Comment 8 2011-02-11 17:44:52 PST

The changes look fine to me overall. Note that this is the first time these classes need to be compiled for the Safari Windows port (WebGL hasn't been enabled there yet), which is why they aren't in the project file and why the link failed.

Adam Barth

Comment 9 2011-02-11 18:01:04 PST

Yeah, I'll obviously add them to the vcproj file before landing.

Kenneth Russell

Comment 10 2011-02-11 18:17:43 PST

Comment on attachment 82173 [details] Patch Looks good to me then.

Adam Barth

Comment 11 2011-02-11 18:30:03 PST

> Looks good to me then. Thanks!

Adam Barth

Comment 12 2011-02-11 18:43:45 PST

Created attachment 82222 [details] patch for win-ews to chew on

Build Bot

Comment 13 2011-02-11 20:10:17 PST

Attachment 82222 [details] did not build on win: Build output: http://queues.webkit.org/results/7874839

Adam Barth

Comment 14 2011-02-11 20:28:56 PST

Created attachment 82228 [details] patch for win-ews to chew on

Build Bot

Comment 15 2011-02-11 21:08:20 PST

Attachment 82228 [details] did not build on win: Build output: http://queues.webkit.org/results/7875791

Adam Barth

Comment 16 2011-02-11 21:38:22 PST

Created attachment 82229 [details] patch for win-ews to chew on

Build Bot

Comment 17 2011-02-11 22:26:54 PST

Attachment 82229 [details] did not build on win: Build output: http://queues.webkit.org/results/7875810

Adam Barth

Comment 18 2011-02-11 23:16:10 PST

Hopefully this one will work. :)

Adam Barth

Comment 19 2011-02-11 23:17:09 PST

Created attachment 82230 [details] patch for win-ews to chew on

Adam Barth

Comment 20 2011-02-12 00:24:40 PST

Committed r78407: <http://trac.webkit.org/changeset/78407>

Peter Kasting

Comment 21 2011-02-12 11:09:41 PST

Comment on attachment 82230 [details] patch for win-ews to chew on Clearing r?

Note You need to log in before you can comment on or make changes to this bug.