Bug 54298

Summary: A little more encapsulation for the heap: Removed CollectorHeapIterator
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, eric, ossy, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+

Geoffrey Garen
Reported 2011-02-11 11:15:59 PST
A little more encapsulation for the heap: Removed CollectorHeapIterator
Attachments
Patch (21.65 KB, patch)
2011-02-11 11:26 PST, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (29.65 KB, patch)
2011-02-11 14:08 PST, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (29.65 KB, patch)
2011-02-11 14:43 PST, Geoffrey Garen 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-02-11 11:26:19 PST
Created attachment 82150 [details] Patch
Early Warning System Bot
Comment 2 2011-02-11 11:55:16 PST
Attachment 82150 [details] did not build on qt: Build output: http://queues.webkit.org/results/7886725
Build Bot
Comment 3 2011-02-11 12:05:21 PST
Attachment 82150 [details] did not build on win: Build output: http://queues.webkit.org/results/7875684
Geoffrey Garen
Comment 4 2011-02-11 14:08:29 PST
Created attachment 82172 [details] Patch
Early Warning System Bot
Comment 5 2011-02-11 14:40:10 PST
Attachment 82172 [details] did not build on qt: Build output: http://queues.webkit.org/results/7884690
Geoffrey Garen
Comment 6 2011-02-11 14:43:47 PST
Created attachment 82182 [details] Patch
Geoffrey Garen
Comment 7 2011-02-11 15:31:27 PST
Committed r78382: <http://trac.webkit.org/changeset/78382>
Build Bot
Comment 8 2011-02-11 15:43:09 PST
Attachment 82172 [details] did not build on win: Build output: http://queues.webkit.org/results/7870793
WebKit Review Bot
Comment 9 2011-02-11 15:50:36 PST
http://trac.webkit.org/changeset/78382 might have broken Qt Linux Release, Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, and Qt Windows 32-bit Release
Csaba Osztrogonác
Comment 10 2011-02-15 09:09:01 PST
(In reply to comment #9) > http://trac.webkit.org/changeset/78382 might have broken Qt Linux Release, Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, and Qt Windows 32-bit Release Sorry for this annoyance, it was an incremental build problem. I filed a new bug report to fix it: https://bugs.webkit.org/show_bug.cgi?id=54466
Note You need to log in before you can comment on or make changes to this bug.