Bug 54245

Summary: Cached JavaScript Parser Data Being Left in Memory Cache
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: WebCore JavaScriptAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch to release SourceProviderCache data from MemoryCache
none
Updated Patch with Windows export of SourceProviderCache::clear() ggaren: review+

Michael Saboff
Reported 2011-02-10 14:29:41 PST
SourceProviderCache data is being left in the MemoryCache for CachedScript objects.
Attachments
Patch to release SourceProviderCache data from MemoryCache (6.81 KB, patch)
2011-02-10 15:03 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Updated Patch with Windows export of SourceProviderCache::clear() (7.52 KB, patch)
2011-02-10 16:13 PST, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2011-02-10 15:03:30 PST
Created attachment 82055 [details] Patch to release SourceProviderCache data from MemoryCache
Build Bot
Comment 2 2011-02-10 15:37:05 PST
Attachment 82055 [details] did not build on win: Build output: http://queues.webkit.org/results/7868463
Michael Saboff
Comment 3 2011-02-10 16:13:11 PST
Created attachment 82068 [details] Updated Patch with Windows export of SourceProviderCache::clear()
Geoffrey Garen
Comment 4 2011-02-10 16:15:42 PST
Comment on attachment 82068 [details] Updated Patch with Windows export of SourceProviderCache::clear() View in context: https://bugs.webkit.org/attachment.cgi?id=82068&action=review r=me > Source/WebCore/ChangeLog:8 > + Added logic in CachedScript to clear SourceProviderCache data in I think it's worth mentioning the improvement you measured on membuster, for the benefit of future readers. > Source/WebCore/loader/cache/CachedScript.cpp:129 > - // FIXME: SourceInfoCache should be wiped out too but not this easily. > + if (m_sourceProviderCache) > + m_sourceProviderCache->clear(); I thought this juxtaposition was cool :).
Oliver Hunt
Comment 5 2011-02-10 16:23:14 PST
Comment on attachment 82068 [details] Updated Patch with Windows export of SourceProviderCache::clear() View in context: https://bugs.webkit.org/attachment.cgi?id=82068&action=review >> Source/WebCore/loader/cache/CachedScript.cpp:129 >> + if (m_sourceProviderCache) >> + m_sourceProviderCache->clear(); > > I thought this juxtaposition was cool :). You should be able to just do m_sourceProviderCache.clear()
Michael Saboff
Comment 6 2011-02-10 18:10:42 PST
Committed r78297: <http://trac.webkit.org/changeset/78297>
Note You need to log in before you can comment on or make changes to this bug.