Bug 54211
| Summary: | WKPageFindClient::didFindString is never called if kWKFindOptionsShowOverlay is not passed to WKPageFindString | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | andersca, sam, sullivan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Adam Roben (:aroben)
If an application calls WKPageFindString, but doesn't pass the kWKFindOptionsShowOverlay flag, the find client's didFindString callback is never called.
You can see in the implementation of FindController::findString that the DidFindString message is only sent if shouldShowOverlay is true. [1]
It seems like either didFindString is misnamed, or we should be calling it even when we're not showing the overlay.
1. http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp?rev=77862#L104
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |