Bug 54205

Summary:

Web Inspector: [STYLES] Suggest CSS property values once Up/Down is pressed with an empty input

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Suggested solution	none
[PATCH] Comment addressed	yurys: review+

Alexander Pavlov (apavlov)

Reported 2011-02-10 06:26:19 PST

Currently nothing happens, but a user should be able to cycle through available values even without entering anything, just pressing Up/Down.

Attachments
[PATCH] Suggested solution (4.27 KB, patch) 2011-02-10 06:49 PST, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
[PATCH] Comment addressed (4.36 KB, patch) 2011-02-10 07:35 PST, Alexander Pavlov (apavlov)	yurys: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2011-02-10 06:49:03 PST

Created attachment 81973 [details] [PATCH] Suggested solution

Alexander Pavlov (apavlov)

Comment 2 2011-02-10 06:53:35 PST

Upstreaming http://code.google.com/p/chromium/issues/detail?id=40784 request regarding empty value auto-completion.

Yury Semikhatsky

Comment 3 2011-02-10 07:27:21 PST

Comment on attachment 81973 [details] [PATCH] Suggested solution View in context: https://bugs.webkit.org/attachment.cgi?id=81973&action=review > Source/WebCore/inspector/front-end/TextPrompt.js:201 > + if ((auto ^ (selectionRange.commonAncestorContainer !== this.element)) && !selectionRange.commonAncestorContainer.isDescendant(this.element)) This expression looks too complex to me. Can you break it down into some simpler pieces?

Alexander Pavlov (apavlov)

Comment 4 2011-02-10 07:35:06 PST

Created attachment 81980 [details] [PATCH] Comment addressed

Alexander Pavlov (apavlov)

Comment 5 2011-02-10 08:05:35 PST

Landed with a variable extracted, as suggested by Yury. Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/CSSCompletions.js M Source/WebCore/inspector/front-end/CSSKeywordCompletions.js M Source/WebCore/inspector/front-end/StylesSidebarPane.js M Source/WebCore/inspector/front-end/TextPrompt.js Committed r78225

Note You need to log in before you can comment on or make changes to this bug.