Bug 54203

Summary: [GTK] http/tests/websocket/tests/handshake-fail-by-maxlength.html is flaky
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, joenotcharles, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch mrobinson: review-

Philippe Normand
Reported 2011-02-10 06:10:35 PST
The timeout there expires too early sometimes. That test needs a refactoring, using body.onload.
Attachments
proposed patch (2.67 KB, patch)
2011-02-10 06:12 PST, Philippe Normand 		mrobinson: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-02-10 06:12:35 PST
Created attachment 81967 [details] proposed patch
Joe Mason
Comment 2 2011-02-10 07:23:51 PST
Not a reviewer, but LGTM
Martin Robinson
Comment 3 2011-02-10 08:35:33 PST
Comment on attachment 81967 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81967&action=review Hrm. Wouldn't putting the timeout and description into startTest remove the flakiness as well. I guess I'm not exactly sure what the issue was. > LayoutTests/http/tests/websocket/tests/handshake-fail-by-maxlength.html:15 > +var successfullyParsed = true; I think this needs to be the last line of JavaScript.
Philippe Normand
Comment 4 2011-02-10 08:43:50 PST
The issue is that the timer is fired too late. Starting it just after the body loaded, like in some other tests, seemed to fix the issue. At least locally. I tried setting the description in startTest() but then there was an error about an undefined variable, I don't recall which exactly
Philippe Normand
Comment 5 2011-02-10 08:45:16 PST
Anyway, some time after that failure I saw a bunch of other websocket tests failing again and just decided to skip them all. Xan backed me up on this.
Martin Robinson
Comment 6 2011-02-17 15:20:14 PST
Comment on attachment 81967 [details] proposed patch r- for the previously mentioned issue.
Eric Seidel (no email)
Comment 7 2011-05-01 17:44:51 PDT
Adam moved the websocket tests over to a real http server and most of the flakiness went away. If you see this again, please re-open.
Philippe Normand
Comment 8 2011-05-02 03:55:31 PDT
Committed r85469: <http://trac.webkit.org/changeset/85469>
Philippe Normand
Comment 9 2011-05-02 09:00:00 PDT
Sorry I meant r85470
Note You need to log in before you can comment on or make changes to this bug.