Bug 54200

Summary: check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Tools / TestsAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
kling: review-
proposed patch kling: review+, kling: commit-queue-

Zoltan Horvath
Reported 2011-02-10 05:57:30 PST
check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
Attachments
proposed patch (1.92 KB, patch)
2011-02-10 05:58 PST, Zoltan Horvath 		kling: review-
DetailsFormatted DiffDiff
proposed patch (1.90 KB, patch)
2011-02-10 06:04 PST, Zoltan Horvath 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2011-02-10 05:58:50 PST
Created attachment 81964 [details] proposed patch
Andreas Kling
Comment 2 2011-02-10 06:01:11 PST
Comment on attachment 81964 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81964&action=review > Tools/Scripts/webkitpy/style/checker_unittest.py:256 > + assertCheck("Tools/MiniBrowser/qt/UrlLoader.cpp", > + "build/include") > + assertNoCheck("Tools/MiniBrowser/qt/UrlLoader.cpp", > + "build/include") Ahrrm...
Zoltan Horvath
Comment 3 2011-02-10 06:04:54 PST
Created attachment 81965 [details] proposed patch
Andreas Kling
Comment 4 2011-02-10 06:08:02 PST
Comment on attachment 81965 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81965&action=review r=me > Tools/Scripts/webkitpy/style/checker_unittest.py:254 > + assertCheck("random_path.cpp", > + "build/include") We're already testing this on line 213. You can leave it out.
Zoltan Horvath
Comment 5 2011-02-10 06:15:52 PST
Thnx, done! Committed r78215. http://trac.webkit.org/changeset/78215
Note You need to log in before you can comment on or make changes to this bug.