Bug 54188

Summary: Remove PCRE source from trunk
Product: WebKit Reporter: Peter Varga <pvarga>
Component: JavaScriptCoreAssignee: Peter Varga <pvarga>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, gustavo.noronha, gustavo, msaboff, ossy, xan.lopez, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch
none
proposed patch v2 none

Peter Varga
Reported 2011-02-10 02:42:14 PST
The PCRE library isn't used anymore. The remaining sources and entries in project files should be removed.
Attachments
proposed patch (400.10 KB, patch)
2011-02-10 02:58 PST, Peter Varga 		no flags
DetailsFormatted DiffDiff
proposed patch v2 (400.21 KB, patch)
2011-02-10 04:17 PST, Peter Varga 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peter Varga
Comment 1 2011-02-10 02:58:06 PST
Created attachment 81943 [details] proposed patch
Collabora GTK+ EWS bot
Comment 2 2011-02-10 04:04:20 PST
Attachment 81943 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7886273
Csaba Osztrogonác
Comment 3 2011-02-10 04:08:54 PST
Comment on attachment 81943 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81943&action=review > Source/JavaScriptCore/GNUmakefile.am:-52 > Source/JavaScriptCore/runtime/StringPrototype.lut.h \ > - Source/JavaScriptCore/pcre/chartables.c Please remove the last backslash: Source/JavaScriptCore/runtime/StringPrototype.lut.h
Peter Varga
Comment 4 2011-02-10 04:17:26 PST
Created attachment 81949 [details] proposed patch v2
Csaba Osztrogonác
Comment 5 2011-02-10 04:47:40 PST
Comment on attachment 81949 [details] proposed patch v2 Great work Peter! We don't need pcre anymore, r=me. Unfortunately EWS bots can't apply vcproj changes because of different line breaks. :( Please make sure you don't break any build, and watch the buildbots. ;)
Csaba Osztrogonác
Comment 6 2011-02-10 07:45:29 PST
Landed in http://trac.webkit.org/changeset/78211
Note You need to log in before you can comment on or make changes to this bug.