Bug 54160

Summary: REGRESSION (r77101) box-shadow sometimes renders incorrectly
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Testcase
none
Patch mitz: review+

Simon Fraser (smfr)
Reported 2011-02-09 19:11:02 PST
Created attachment 81912 [details] Testcase The attached testcase shows an issue where a box-shadow gets drawn incorrectly behind another element sometimes.
Attachments
Testcase (527 bytes, text/html)
2011-02-09 19:11 PST, Simon Fraser (smfr) 		no flags
Details
Patch (15.61 KB, patch)
2011-02-09 21:02 PST, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-02-09 20:29:10 PST
The bug is that endShadowLayer() does graphicsContext->clipToImageBuffer(m_layerImage, FloatRect(m_layerOrigin, m_layerImage->size())); but not all of m_layerImage->size() was cleared, so may contains bits from some previous shadow.
Simon Fraser (smfr)
Comment 2 2011-02-09 21:02:21 PST
Created attachment 81918 [details] Patch
Simon Fraser (smfr)
Comment 3 2011-02-09 21:16:34 PST
http://trac.webkit.org/changeset/78173
Note You need to log in before you can comment on or make changes to this bug.