Bug 54155

Summary: Add randomValuesFromOS for OS(WINDOWS)
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on: 54083    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch (Added CRASH() for the error case) none

Patrick R. Gansterer
Reported 2011-02-09 17:33:40 PST
see patch
Attachments
Patch (2.34 KB, patch)
2011-02-09 17:38 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (Added CRASH() for the error case) (2.41 KB, patch)
2011-02-09 17:55 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-02-09 17:38:47 PST
Created attachment 81902 [details] Patch
WebKit Review Bot
Comment 2 2011-02-09 17:40:47 PST
Attachment 81902 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OSRandomSource.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Patrick R. Gansterer
Comment 3 2011-02-09 17:55:08 PST
Created attachment 81904 [details] Patch (Added CRASH() for the error case)
WebKit Review Bot
Comment 4 2011-02-09 17:56:54 PST
Attachment 81904 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OSRandomSource.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 5 2011-02-09 19:00:00 PST
Comment on attachment 81904 [details] Patch (Added CRASH() for the error case) Silly windows include header order dependencies. Thanks!
WebKit Commit Bot
Comment 6 2011-02-10 05:15:40 PST
Comment on attachment 81904 [details] Patch (Added CRASH() for the error case) Clearing flags on attachment: 81904 Committed r78208: <http://trac.webkit.org/changeset/78208>
WebKit Commit Bot
Comment 7 2011-02-10 05:15:44 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 8 2011-02-10 07:02:44 PST
The commit-queue encountered the following flaky tests while processing attachment 81904 [details]: http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.