Bug 54155 - Add randomValuesFromOS for OS(WINDOWS)
Summary: Add randomValuesFromOS for OS(WINDOWS)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 54083
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-09 17:33 PST by Patrick R. Gansterer
Modified: 2011-02-10 07:02 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.34 KB, patch)
2011-02-09 17:38 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (Added CRASH() for the error case) (2.41 KB, patch)
2011-02-09 17:55 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-02-09 17:33:40 PST
see patch
Comment 1 Patrick R. Gansterer 2011-02-09 17:38:47 PST
Created attachment 81902 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-09 17:40:47 PST
Attachment 81902 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/OSRandomSource.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Patrick R. Gansterer 2011-02-09 17:55:08 PST
Created attachment 81904 [details]
Patch (Added CRASH() for the error case)
Comment 4 WebKit Review Bot 2011-02-09 17:56:54 PST
Attachment 81904 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/OSRandomSource.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Adam Barth 2011-02-09 19:00:00 PST
Comment on attachment 81904 [details]
Patch (Added CRASH() for the error case)

Silly windows include header order dependencies.  Thanks!
Comment 6 WebKit Commit Bot 2011-02-10 05:15:40 PST
Comment on attachment 81904 [details]
Patch (Added CRASH() for the error case)

Clearing flags on attachment: 81904

Committed r78208: <http://trac.webkit.org/changeset/78208>
Comment 7 WebKit Commit Bot 2011-02-10 05:15:44 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Commit Bot 2011-02-10 07:02:44 PST
The commit-queue encountered the following flaky tests while processing attachment 81904 [details]:

http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.