Bug 54149 – [chromium] add WebIDBObjectStore::clear method

• Component: New Bugs
• Status: RESOLVED FIXED

[chromium] add WebIDBObjectStore::clear method

Created attachment 81882 [details]
Patch

This implements http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBObjectStore-clear

Jeremy, is there a meta bug this should block?

[Jeremy Orlow]

Comment on attachment 81882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81882&action=review

r=me

> Source/WebKit/chromium/public/WebIDBObjectStore.h:72
> +    virtual void clear(WebIDBCallbacks* callbacks, const WebIDBTransaction& transaction, WebExceptionCode& ec) { WEBKIT_ASSERT_NOT_REACHED(); }

don't include names (can you fix the others please?)

[Darin Fisher (:fishd, Google)]

> > Source/WebKit/chromium/public/WebIDBObjectStore.h:72
> > +    virtual void clear(WebIDBCallbacks* callbacks, const WebIDBTransaction& transaction, WebExceptionCode& ec) { WEBKIT_ASSERT_NOT_REACHED(); }
> 
> don't include names (can you fix the others please?)

Just to clarify, the rule is that you should exclude parameter names that do not add information.  In this case, the parameter names are all based on the type names, so they can be excluded.

You should name parameters when it is helpful to do so.  For example, if a function takes a bool or int parameter, it is often helpful to give that parameter a descriptive name.

Created attachment 81936 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 81936 [details]
Patch

Clearing flags on attachment: 81936

Committed r78207: <http://trac.webkit.org/changeset/78207>