Bug 54127
Summary: | [chromium] rebaseline tool does not follows fallback sequence in Mac | ||
---|---|---|---|
Product: | WebKit | Reporter: | Xiaomei Ji <xji> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | dpranke, eric, koz, mihaip |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Mac | ||
OS: | OS X 10.5 | ||
Bug Depends on: | 54248 | ||
Bug Blocks: |
Xiaomei Ji
Chromium mac bot runs on Leopard.
The fallback sequence is http://google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py&q=baseline_search_path&exact_package=chromium&sa=N&cd=8&ct=rc.
If chromium-mac result is different from result in mac-leopard/, but the same as result in mac/, instead of rebaseline the chromium-mac result, rebaseline tool ignores this txt file (seems precedes mac over mac-leopard).
For an example: pop-up-button-text-alignment-and-direction has different expected results in mac and mac-leopard, its txt result in chromium-mac is the same as that in mac/, rebaseline tool will not rebase this txt file in chromium-mac. But the bot will show the test as failure.
110209 10:10:05 rebaseline_chromium_webkit_tests.py:91 INFO ------------------- Extracting and adding new baselines: mac -------------------
110209 10:10:28 rebaseline_chromium_webkit_tests.py:354 INFO Test 1: fast/text/international/pop-up-button-text-alignment-and-direction.html
110209 10:10:28 rebaseline_chromium_webkit_tests.py:369 INFO .txt file found in archive.
110209 10:10:28 rebaseline_chromium_webkit_tests.py:456 INFO Found same baseline at /Volumes/leopard/export/chromium/src/third_party/WebKit/LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt
110209 10:10:28 rebaseline_chromium_webkit_tests.py:365 INFO .png file not in archive.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Mihai Parparita
Dirk, will your patch on bug 54248 fix this too?
Dirk Pranke
theoretically, yes, I think so.
Stephen Chenney
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.