Bug 54100

Summary:

Web Inspector: InspectorAgent should know nothing about InspectorController instance.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[patch] initial version	pfeldman: review-
[patch] second version	none
[patch] second version with assert	none

Ilya Tikhonovsky

Reported 2011-02-09 07:01:05 PST

%subj%

Attachments
[patch] initial version (5.78 KB, patch) 2011-02-09 07:02 PST, Ilya Tikhonovsky	pfeldman: review-	Details Formatted Diff Diff
[patch] second version (6.28 KB, patch) 2011-02-09 07:21 PST, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
[patch] second version with assert (6.32 KB, patch) 2011-02-09 08:29 PST, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2011-02-09 07:02:49 PST

Created attachment 81804 [details] [patch] initial version

Pavel Feldman

Comment 2 2011-02-09 07:14:56 PST

Comment on attachment 81804 [details] [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=81804&action=review > Source/WebCore/inspector/InspectorAgent.cpp:202 > + m_domAgent->setDocument(m_inspectedPage->mainFrame()->document()); While you are here, please nuke setDocument call here - it is done from within pushDataCollectedOffline. > Source/WebCore/inspector/InspectorController.cpp:117 > + m_inspectorAgent->disconnectFrontend(); InspectorAgent::disconnectFrontend is manipulating front-end. Hence it should be called before the m_inspectorFrontend.clear() above. > Source/WebCore/inspector/InspectorController.cpp:146 > + if (!m_inspectorFrontend) Now that you know that front-end does not exist, why checking for m_inspectorFrontend here?

Ilya Tikhonovsky

Comment 3 2011-02-09 07:21:38 PST

Created attachment 81809 [details] [patch] second version comments addressed

Ilya Tikhonovsky

Comment 4 2011-02-09 08:29:11 PST

Created attachment 81815 [details] [patch] second version with assert

Ilya Tikhonovsky

Comment 5 2011-02-09 08:32:23 PST

Comment on attachment 81815 [details] [patch] second version with assert Clearing flags on attachment: 81815 Committed r78056: <http://trac.webkit.org/changeset/78056>

Ilya Tikhonovsky

Comment 6 2011-02-09 08:32:34 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.