Bug 54092

Summary: Extra separator after Select All in context menu
Product: WebKit Reporter: Christian Dywan <christian>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Move spelling option menu separator to non-GTK+port guards none

Christian Dywan
Reported 2011-02-09 05:12:38 PST
There is an extra separator after Select All in the context menu.
Attachments
Move spelling option menu separator to non-GTK+port guards (1.83 KB, patch)
2011-02-09 05:53 PST, Christian Dywan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Christian Dywan
Comment 1 2011-02-09 05:53:57 PST
Created attachment 81794 [details] Move spelling option menu separator to non-GTK+port guards The separator comes from the spelling option menu which the GTK+ port doesn't show. So the separator needs to be moved into non-GTK+ port guards.
Gustavo Noronha (kov)
Comment 2 2011-02-14 08:33:40 PST
Comment on attachment 81794 [details] Move spelling option menu separator to non-GTK+port guards View in context: https://bugs.webkit.org/attachment.cgi?id=81794&action=review > Source/WebCore/page/ContextMenuController.cpp:894 > #ifndef BUILDING_ON_TIGER > #if !PLATFORM(GTK) > + appendItem(*separatorItem(), m_contextMenu.get()); This looks right ot me, but we're also affecting Mac here. Although it does look like it would work as intended for them as well, better check with someone from mac land.
Brent Fulgham
Comment 3 2011-04-11 13:49:49 PDT
Comment on attachment 81794 [details] Move spelling option menu separator to non-GTK+port guards View in context: https://bugs.webkit.org/attachment.cgi?id=81794&action=review >> Source/WebCore/page/ContextMenuController.cpp:894 >> + appendItem(*separatorItem(), m_contextMenu.get()); > > This looks right ot me, but we're also affecting Mac here. Although it does look like it would work as intended for them as well, better check with someone from mac land. This may not do the right thing for Tiger builds. The append will only happen for more recent OS versions, but perhaps no one cares anymore?
Eric Seidel (no email)
Comment 4 2011-04-26 15:29:50 PDT
Comment on attachment 81794 [details] Move spelling option menu separator to non-GTK+port guards Looks fine. If this doesn't break anything in the CQ, it's fine. Please let the cq land it to be sure.
WebKit Commit Bot
Comment 5 2011-04-26 16:57:48 PDT
Comment on attachment 81794 [details] Move spelling option menu separator to non-GTK+port guards Clearing flags on attachment: 81794 Committed r84983: <http://trac.webkit.org/changeset/84983>
WebKit Commit Bot
Comment 6 2011-04-26 16:57:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.