Bug 54057

Summary: [GTK] Build break with 2.18.3
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2011-02-08 20:46:50 PST
I got below error message and I realized that GTK+2.18.3 doesn't have gtk_range_get_min_slider_size. But configure.ac indicate GTK_REQUIRED_VERSION as 2.10. Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp: In member function ‘void WebCore::ScrollbarThemeGtk::updateThemeProperties()’: Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp:62:74: error: ‘gtk_range_get_min_slider_size’ was not declared in this scope CXX Source/WebCore/platform/gtk/libwebkitgtk_1_0_la-WidgetGtk.lo CXX Source/WebCore/platform/gtk/libwebkitgtk_1_0_la-WidgetRenderingContext.lo CXX Source/WebCore/platform/image-decoders/bmp/libwebkitgtk_1_0_la-BMPImageDecoder.lo CXX Source/WebCore/platform/image-decoders/bmp/libwebkitgtk_1_0_la-BMPImageReader.lo CXX Source/WebCore/platform/image-decoders/cairo/libwebkitgtk_1_0_la-ImageDecoderCairo.lo make[1]: *** [Source/WebCore/platform/gtk/libwebkitgtk_1_0_la-ScrollbarThemeGtk2.lo] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/workspace/gtk_webkit' make: *** [all] Error 2
Attachments
Patch (983 bytes, patch)
2011-02-10 17:16 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (978 bytes, patch)
2011-02-10 17:55 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-02-10 17:16:43 PST
Created attachment 82075 [details] Patch
Martin Robinson
Comment 2 2011-02-10 17:46:19 PST
Comment on attachment 82075 [details] Patch I believe you can just include GtkVersioning.h in the RenderThemeGtk2.cpp.
Ryuan Choi
Comment 3 2011-02-10 17:55:50 PST
Created attachment 82081 [details] Patch
WebKit Commit Bot
Comment 4 2011-02-11 00:26:15 PST
Comment on attachment 82081 [details] Patch Clearing flags on attachment: 82081 Committed r78320: <http://trac.webkit.org/changeset/78320>
WebKit Commit Bot
Comment 5 2011-02-11 00:26:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.