Bug 54045

Summary: Fix scaling and thread safety of FFTFrameFFTW
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch kbr: review+

Chris Rogers
Reported 2011-02-08 16:20:53 PST
Fix scaling and thread safety of FFTFrameFFTW
Attachments
Patch (6.90 KB, patch)
2011-02-08 16:25 PST, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (9.82 KB, patch)
2011-02-08 17:27 PST, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (9.61 KB, patch)
2011-02-08 17:30 PST, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-02-08 16:25:05 PST
Created attachment 81714 [details] Patch
Kenneth Russell
Comment 2 2011-02-08 17:01:38 PST
Comment on attachment 81714 [details] Patch This mostly looks good -- thanks for fixing my bugs -- but as we discussed offline we should add a static initialize() method to FFTFrame to allow the mutex to be created from a known good place, before multithreaded allocation of FFTFrames might start.
Chris Rogers
Comment 3 2011-02-08 17:27:49 PST
Created attachment 81722 [details] Patch
Chris Rogers
Comment 4 2011-02-08 17:30:57 PST
Created attachment 81723 [details] Patch
Chris Rogers
Comment 5 2011-02-08 17:31:54 PST
Added the static initialize() method.
Kenneth Russell
Comment 6 2011-02-08 17:34:46 PST
Comment on attachment 81723 [details] Patch Looks fine. Please regenerate the ChangeLog when landing to pick up the changes to newly modified files.
Chris Rogers
Comment 7 2011-02-09 12:03:38 PST
Committed r78102: <http://trac.webkit.org/changeset/78102>
Note You need to log in before you can comment on or make changes to this bug.