Summary: | [GTK] Menulists do not follow text direction when rendering options with right-to-left text | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, gustavo, xji | ||||||
Priority: | P3 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Martin Robinson
2011-02-08 14:53:24 PST
Created attachment 81704 [details]
Patch
Comment on attachment 81704 [details]
Patch
Removing r?, as I think this patch is incomplete.
Created attachment 81712 [details]
Patch
Comment on attachment 81712 [details]
Patch
The rationale behind this change seems a bit obscure in general. I guess at the very least you should say why do you want to do this.
(In reply to comment #4) > (From update of attachment 81712 [details]) > The rationale behind this change seems a bit obscure in general. I guess at the very least you should say why do you want to do this. I can update the ChangeLog to say something like: Do not follow the natural writing direction of menu list text, but do follow the menu list writing direction. This matches the behavior of Chromium and modern OS X machines. This will mean that the menulist text-alignment will override the natural bidi alignment of the text. (In reply to comment #4) > (From update of attachment 81712 [details]) > The rationale behind this change seems a bit obscure in general. I guess at the very least you should say why do you want to do this. It is proposed and accepted in HTML5 http://dev.w3.org/html5/spec/Overview.html#text-rendered-in-native-user-interfaces Comment on attachment 81712 [details]
Patch
OK.
Comment on attachment 81712 [details] Patch Rejecting attachment 81712 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2 Last 500 characters of output: k FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej patching file LayoutTests/platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum LayoutTests/platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png already exists at /Projects/CommitQueue/Tools/Scripts/svn-apply line 253. Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 25 Full output: http://queues.webkit.org/results/8511165 Committed r85066: <http://trac.webkit.org/changeset/85066> |