Bug 54017

Summary: drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarrin, enne, eric, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch kbr: review+

Zhenyao Mo
Reported 2011-02-08 09:54:02 PST
WebGL spec says: " If count is greater than zero, then a non-null WebGLBuffer must be bound to the ELEMENT_ARRAY_BUFFER binding point or an INVALID_OPERATION error will be generated." We should avoid sending down the call to underlying GL if no buffer is bound to the ELEMENT_ARRAY_BUFFER.
Attachments
Patch (3.65 KB, patch)
2011-02-08 10:24 PST, Zhenyao Mo 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2011-02-08 10:24:37 PST
Created attachment 81658 [details] Patch
Kenneth Russell
Comment 2 2011-02-08 10:28:36 PST
Comment on attachment 81658 [details] Patch Looks good.
Zhenyao Mo
Comment 3 2011-02-08 10:50:44 PST
Landed in http://trac.webkit.org/changeset/77956
WebKit Review Bot
Comment 4 2011-02-08 11:34:50 PST
http://trac.webkit.org/changeset/77956 might have broken Qt Linux Release The following tests are not passing: http/tests/websocket/tests/workers/close-in-onmessage-crash.html
Note You need to log in before you can comment on or make changes to this bug.