Bug 54009

Summary: [WK2] LayerTreeContext is used outside the ACCELERATED_COMPOSITING guards but not defined in DrawingAreaProxy.h
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 52805    
Attachments:
Description Flags
Proposed patch mrobinson: review+

Alejandro G. Castro
Reported 2011-02-08 08:56:11 PST
After r77546 LayerTreeContext is used outside the ACCELERATED_COMPOSITING guards: diff --git a/Source/WebKit2/UIProcess/DrawingAreaProxy.h b/Source/WebKit2/UIProcess/DrawingAreaProxy.h index 1639668..0e3b555 100644 --- a/Source/WebKit2/UIProcess/DrawingAreaProxy.h +++ b/Source/WebKit2/UIProcess/DrawingAreaProxy.h @@ -97,7 +97,7 @@ private: // CoreIPC message handlers. // FIXME: These should be pure virtual. virtual void update(uint64_t sequenceNumber, const UpdateInfo&) { } - virtual void didSetSize(uint64_t sequenceNumber, const UpdateInfo&) { } + virtual void didSetSize(uint64_t sequenceNumber, const UpdateInfo&, const LayerTreeContext&) { } #if USE(ACCELERATED_COMPOSITING) virtual void enterAcceleratedCompositingMode(uint64_t sequenceNumber, const LayerTreeContext&) { } virtual void exitAcceleratedCompositingMode(uint64_t sequenceNumber) { } But it is forward declared inside the guards in the same file.
Attachments
Proposed patch (1.77 KB, patch)
2011-02-08 09:03 PST, Alejandro G. Castro 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2011-02-08 09:03:35 PST
Created attachment 81643 [details] Proposed patch
Alejandro G. Castro
Comment 2 2011-02-08 23:22:41 PST
Landed http://trac.webkit.org/changeset/78021
Note You need to log in before you can comment on or make changes to this bug.