Bug 53994
| Summary: | PlatformCAAnimation(const PlatformCAAnimation*) on Mac leaks, doesn't work correctly | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | cmarrin, simon.fraser |
| Priority: | P2 | Keywords: | InRadar, PlatformOnly |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Adam Roben (:aroben)
The PlatformCAAnimation(const PlatformCAAnimation*) constructor on Mac [1] leaks and doesn't initialize the PlatformCAAnimation correctly. Rather than initializing "this", it creates and throws away a new PlatformCAAnimation object. This results in leaks [2], and I can only assume results in incorrect rendering.
1. http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm?rev=73731#L190
2. http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r77920%20(14677)/DumpRenderTree-leaks.txt
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
<rdar://problem/8971075>
Adam Roben (:aroben)
Seems like this function could be implemented as simply as:
m_type = animation->animationType();
m_animation.adoptNS([animation->platformAnimation() copy]);
Adam Roben (:aroben)
I wonder if PlatformCAAnimation(PlatformAnimationRef) should be using -copy, too?
Simon Fraser (smfr)
*** This bug has been marked as a duplicate of bug 53175 ***