Summary: | Remove orphan code from old parser | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, commit-queue, eric, ossy, webkit-ews, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Adam Barth
2011-02-08 00:00:43 PST
Created attachment 81607 [details]
Patch
Comment on attachment 81607 [details]
Patch
OK.
Attachment 81607 [details] did not build on qt: Build output: http://queues.webkit.org/results/7862004 Comment on attachment 81607 [details]
Patch
cq-, because it broke Qt build
(In reply to comment #4) > (From update of attachment 81607 [details]) > cq-, because it broke Qt build It seems it isn't a Qt related problem, but a general WebKit2 releated problem: Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h needs HTMLParserQuirks Attachment 81607 [details] did not build on win: Build output: http://queues.webkit.org/results/7756007 Attachment 81607 [details] did not build on mac: Build output: http://queues.webkit.org/results/7797047 Created attachment 81654 [details]
Patch
Comment on attachment 81654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81654&action=review > Source/WebCore/html/HTMLParserErrorCodes.cpp:-34 > - "%tag1 is not allowed inside %tag2. Moving %tag1 into the nearest enclosing <table>.", Do we still get error messages like this in the web inspector, or did we lose that feature when we added the new parser? Comment on attachment 81654 [details] Patch Clearing flags on attachment: 81654 Committed r77963: <http://trac.webkit.org/changeset/77963> All reviewed patches have been landed. Closing bug. (In reply to comment #9) > (From update of attachment 81654 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81654&action=review > > > Source/WebCore/html/HTMLParserErrorCodes.cpp:-34 > > - "%tag1 is not allowed inside %tag2. Moving %tag1 into the nearest enclosing <table>.", > > Do we still get error messages like this in the web inspector, or did we lose that feature when we added the new parser? Yes, we lost all HTML error reporting with the new parser. Adam has a patch up for review which adds the first of it back. (Entertainingly, it took over 6 months to notice.) The new parser is designed with reporting in mind. We mostly didn't implement it at the time due to lack of testing (it was not on the critical path). Implementing parse error reporting is in https://bugs.webkit.org/show_bug.cgi?id=41187 |