Bug 53984

Summary: Remove orphan code from old parser
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eric, ossy, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2011-02-08 00:00:43 PST
Remove orphan code from old parser
Attachments
Patch (20.15 KB, patch)
2011-02-08 00:02 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (22.81 KB, patch)
2011-02-08 09:43 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-02-08 00:02:06 PST
Created attachment 81607 [details] Patch
Eric Seidel (no email)
Comment 2 2011-02-08 00:11:34 PST
Comment on attachment 81607 [details] Patch OK.
Early Warning System Bot
Comment 3 2011-02-08 00:20:45 PST
Attachment 81607 [details] did not build on qt: Build output: http://queues.webkit.org/results/7862004
Csaba Osztrogonác
Comment 4 2011-02-08 00:23:01 PST
Comment on attachment 81607 [details] Patch cq-, because it broke Qt build
Csaba Osztrogonác
Comment 5 2011-02-08 00:27:33 PST
(In reply to comment #4) > (From update of attachment 81607 [details]) > cq-, because it broke Qt build It seems it isn't a Qt related problem, but a general WebKit2 releated problem: Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h needs HTMLParserQuirks
Build Bot
Comment 6 2011-02-08 00:32:29 PST
Attachment 81607 [details] did not build on win: Build output: http://queues.webkit.org/results/7756007
WebKit Review Bot
Comment 7 2011-02-08 03:53:23 PST
Attachment 81607 [details] did not build on mac: Build output: http://queues.webkit.org/results/7797047
Adam Barth
Comment 8 2011-02-08 09:43:07 PST
Created attachment 81654 [details] Patch
Darin Adler
Comment 9 2011-02-08 10:08:20 PST
Comment on attachment 81654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81654&action=review > Source/WebCore/html/HTMLParserErrorCodes.cpp:-34 > - "%tag1 is not allowed inside %tag2. Moving %tag1 into the nearest enclosing <table>.", Do we still get error messages like this in the web inspector, or did we lose that feature when we added the new parser?
WebKit Commit Bot
Comment 10 2011-02-08 12:17:26 PST
Comment on attachment 81654 [details] Patch Clearing flags on attachment: 81654 Committed r77963: <http://trac.webkit.org/changeset/77963>
WebKit Commit Bot
Comment 11 2011-02-08 12:17:31 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 12 2011-02-08 12:56:35 PST
(In reply to comment #9) > (From update of attachment 81654 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81654&action=review > > > Source/WebCore/html/HTMLParserErrorCodes.cpp:-34 > > - "%tag1 is not allowed inside %tag2. Moving %tag1 into the nearest enclosing <table>.", > > Do we still get error messages like this in the web inspector, or did we lose that feature when we added the new parser? Yes, we lost all HTML error reporting with the new parser. Adam has a patch up for review which adds the first of it back. (Entertainingly, it took over 6 months to notice.) The new parser is designed with reporting in mind. We mostly didn't implement it at the time due to lack of testing (it was not on the critical path).
Adam Barth
Comment 13 2011-02-08 13:34:08 PST
Implementing parse error reporting is in https://bugs.webkit.org/show_bug.cgi?id=41187
Note You need to log in before you can comment on or make changes to this bug.