| Summary: | Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Orlow <jorlow> | ||||||
| Component: | New Bugs | Assignee: | Jeremy Orlow <jorlow> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andreip, dglazkov, dgrogan, hans, japhet, webkit.review.bot, zmo | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jeremy Orlow
2011-02-07 21:21:35 PST
Created attachment 81580 [details]
Patch
please review Attachment 81580 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7740009 Attachment 81580 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7828007 Created attachment 81708 [details]
Patch
Comment on attachment 81708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81708&action=review > Source/WebCore/storage/IDBDatabase.cpp:143 > +ScriptExecutionContext* IDBDatabase::scriptExecutionContext() const > +{ > + return ActiveDOMObject::scriptExecutionContext(); > +} Is there a reason we're overriding this if we're just calling straight to ActiveDOMObject? > Source/WebCore/storage/IDBRequest.cpp:150 > + // If there ever are events that are associated with a database but not have a Grammar nit: "but not have" -> "but do not have" > Source/WebCore/storage/IDBTransaction.cpp:116 > +ScriptExecutionContext* IDBTransaction::scriptExecutionContext() const > +{ > + return ActiveDOMObject::scriptExecutionContext(); > +} > + Same as above: is there a reason for this? Am I missing something obvious? (In reply to comment #6) > (From update of attachment 81708 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81708&action=review > > > Source/WebCore/storage/IDBDatabase.cpp:143 > > +ScriptExecutionContext* IDBDatabase::scriptExecutionContext() const > > +{ > > + return ActiveDOMObject::scriptExecutionContext(); > > +} > > Is there a reason we're overriding this if we're just calling straight to ActiveDOMObject? In eventTarget.h: virtual ScriptExecutionContext* scriptExecutionContext() const = 0; Committed r78005: <http://trac.webkit.org/changeset/78005> storage/indexeddb/request-event-propagation.html storage/indexeddb/transaction-event-propagation.html are failing on chromium+webkit bots. |