Summary: | Add bundle API to get the background color of a frame | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Sam Weinig
2011-02-07 15:10:33 PST
Created attachment 81537 [details]
Patch
Comment on attachment 81537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81537&action=review > Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:527 > + All these early returns will cause the out parameters to be uninitialized. Can m_coreFrame ever be null? Should we make getBodyBackgroundColor return whether it was successful or not? > Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:531 > + *alpha = color.alpha(); We want the color components to be between 0 and 1, this doesn't do that. Created attachment 81543 [details]
Patch
|