Bug 53952

Summary: Add bundle API to get the background color of a frame
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Sam Weinig
Reported 2011-02-07 15:10:33 PST
Add bundle API to get the background color of a frame
Attachments
Patch (4.31 KB, patch)
2011-02-07 15:11 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (4.53 KB, patch)
2011-02-07 15:43 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-02-07 15:11:34 PST
Created attachment 81537 [details] Patch
Anders Carlsson
Comment 2 2011-02-07 15:14:55 PST
Comment on attachment 81537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81537&action=review > Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:527 > + All these early returns will cause the out parameters to be uninitialized. Can m_coreFrame ever be null? Should we make getBodyBackgroundColor return whether it was successful or not? > Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:531 > + *alpha = color.alpha(); We want the color components to be between 0 and 1, this doesn't do that.
Sam Weinig
Comment 3 2011-02-07 15:43:36 PST
Created attachment 81543 [details] Patch
Sam Weinig
Comment 4 2011-02-07 15:46:30 PST
Landed in r77856.
Note You need to log in before you can comment on or make changes to this bug.