Bug 53952

Summary: Add bundle API to get the background color of a frame
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Description Sam Weinig 2011-02-07 15:10:33 PST
Add bundle API to get the background color of a frame
Comment 1 Sam Weinig 2011-02-07 15:11:34 PST
Created attachment 81537 [details]
Patch
Comment 2 Anders Carlsson 2011-02-07 15:14:55 PST
Comment on attachment 81537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81537&action=review

> Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:527
> +

All these early returns will cause the out parameters to be uninitialized. Can m_coreFrame ever be null? 

Should we make getBodyBackgroundColor return whether it was successful or not?

> Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:531
> +    *alpha = color.alpha();

We want the color components to be between 0 and 1, this doesn't do that.
Comment 3 Sam Weinig 2011-02-07 15:43:36 PST
Created attachment 81543 [details]
Patch
Comment 4 Sam Weinig 2011-02-07 15:46:30 PST
Landed in r77856.