Bug 53949 – ImageDecoder.h hardcodes RGBA byteorder on Skia

• Component: Images
• Status: RESOLVED FIXED

[George Wright]

At the moment the setRGBA function in ImageDecoder.h hard codes the colour byte order:

*dest = (a << 24 | r << 16 | g << 8 | b);

In Skia's case this should use Skia's helper function SkPackARGB32.

[George Wright]

Created attachment 81531 [details]
Use SkPackARGB32 in Skia's case

Patch to use SkPackARGB32 in Skia's case.

[Eric Seidel (no email)]

I'm confused why this needs to be in a shared file.

[Peter Kasting]

This looks OK to me.

(In reply to comment #2)
> I'm confused why this needs to be in a shared file.

It needs to be inlined into all the decoders.

[Adam Barth]

Comment on attachment 81531 [details]
Use SkPackARGB32 in Skia's case

This change is fine, but it illustrates some of the design problems with this class.

[Patrick R. Gansterer]

Comment on attachment 81531 [details]
Use SkPackARGB32 in Skia's case

cq+ as requested by gw280 on IRC

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 81531 [details]:

http/tests/websocket/tests/error-detect.html bug 54012 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 81531 [details]
Use SkPackARGB32 in Skia's case

Clearing flags on attachment: 81531

Committed r77946: <http://trac.webkit.org/changeset/77946>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.