Summary: | ImageDecoder.h hardcodes RGBA byteorder on Skia | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | George Wright <gwright> | ||||
Component: | Images | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, pkasting | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
George Wright
2011-02-07 14:56:34 PST
Created attachment 81531 [details]
Use SkPackARGB32 in Skia's case
Patch to use SkPackARGB32 in Skia's case.
I'm confused why this needs to be in a shared file. This looks OK to me. (In reply to comment #2) > I'm confused why this needs to be in a shared file. It needs to be inlined into all the decoders. Comment on attachment 81531 [details]
Use SkPackARGB32 in Skia's case
This change is fine, but it illustrates some of the design problems with this class.
Comment on attachment 81531 [details]
Use SkPackARGB32 in Skia's case
cq+ as requested by gw280 on IRC
The commit-queue encountered the following flaky tests while processing attachment 81531 [details]: http/tests/websocket/tests/error-detect.html bug 54012 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 81531 [details] Use SkPackARGB32 in Skia's case Clearing flags on attachment: 81531 Committed r77946: <http://trac.webkit.org/changeset/77946> All reviewed patches have been landed. Closing bug. |