Bug 53929 – check-style should not complain about code in icu directories

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Darin Adler]

check-style should not complain about pasted ICU code in UnicodeMacrosFromICU.h; those are using the ICU style

[Daniel Bates]

(In reply to comment #0)
> check-style should not complain about pasted ICU code in
> UnicodeMacrosFromICU.h; those are using the ICU style

UnicodeMacrosFromICU.h was removed in the patch for bug #128106, <https://trac.webkit.org/changeset/163315>. Having said that we still have imported ICU headers, say in Source/WebCore/icu, and check-webkit-style should not warn about style issues in such files.

[Daniel Bates]

For completeness, this issue caught my eye because of the deluge of style issues reported on each iteration of the patch for bug #160629 (attachment 297271 [details]), which imports more ICU headers.

[Daniel Bates]

Created attachment 297287 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 297287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297287&action=review

> Tools/Scripts/webkitpy/style/checker.py:327
> +  ]

Style: Indentation of this seems weird. Should this have 4 spaces like the block below this?

[Daniel Bates]

(In reply to comment #4)
> Comment on attachment 297287 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297287&action=review
> 
> > Tools/Scripts/webkitpy/style/checker.py:327
> > +  ]
> 
> Style: Indentation of this seems weird. Should this have 4 spaces like the
> block below this?

Wow, style bot failure. Will fix.

[Daniel Bates]

Committed r209902: <http://trac.webkit.org/changeset/209902>