Bug 53928

Summary: [Mac] spatial navigation is not set to false in DumpRenderTree explicitly
Product: WebKit Reporter: Chang Shu <cshu>
Component: Tools / TestsAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 49261    
Attachments:
Description Flags
fix patch none

Chang Shu
Reported 2011-02-07 10:36:28 PST
The preference in DumpRenderTree (Mac version) is missing a call to [preferences setSpatialNavigationEnabled:NO]. This may cause flaky tests where spatial navigation is enabled by accident.
Attachments
fix patch (1.31 KB, patch)
2011-02-07 10:47 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2011-02-07 10:47:51 PST
Created attachment 81491 [details] fix patch
Chang Shu
Comment 2 2011-02-07 12:52:06 PST
Comment on attachment 81491 [details] fix patch Clearing flags on attachment: 81491 Committed r77836: <http://trac.webkit.org/changeset/77836>
Chang Shu
Comment 3 2011-02-07 12:53:16 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2011-02-07 13:21:04 PST
http://trac.webkit.org/changeset/77836 might have broken Qt Linux Release
Chang Shu
Comment 5 2011-02-07 13:41:19 PST
(In reply to comment #4) > http://trac.webkit.org/changeset/77836 might have broken Qt Linux Release The patch only touches one .mm file. It shouldn't break Qt builds or tests.
Note You need to log in before you can comment on or make changes to this bug.