Bug 53921

Summary: [Qt] fast/dom/nodesFromRect-links-and-text.html crashes in debug mode
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: robert, tonikitoo
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 48957, 53488    
Attachments:
Description Flags
GDB backtrace in debug mode (r53488)
none
Patch none

Description Csaba Osztrogonác 2011-02-07 09:24:20 PST
Created attachment 81480 [details]
GDB backtrace in debug mode (r53488)

fast/dom/nodesFromRect-links-and-text.html crashes in debug 
mode because of an assertion. (long long time ago)

GDB backtrace: <attached> (r53488)
Comment 1 Antonio Gomes 2011-02-07 09:30:07 PST
Robert, it sounds related to your change.
Comment 2 Csaba Osztrogonác 2011-02-07 09:33:05 PST
(In reply to comment #1)
> Robert, it sounds related to your change.

Yes. I got it, it crashed from http://trac.webkit.org/changeset/75189 .
Comment 3 Robert Hogan 2011-02-08 11:44:25 PST
Created attachment 81671 [details]
Patch
Comment 4 Robert Hogan 2011-02-08 11:45:28 PST
(In reply to comment #1)
> Robert, it sounds related to your change.

Yes siree, missed the copy constructor for QDRTNode. QVariant uses it.
Comment 5 Antonio Gomes 2011-02-08 13:09:44 PST
Comment on attachment 81671 [details]
Patch

Do you need to upskip a tesT?
Comment 6 Csaba Osztrogonác 2011-02-09 03:12:29 PST
(In reply to comment #5)
> (From update of attachment 81671 [details])
> Do you need to upskip a tesT?

No, fast/dom/nodesFromRect-links-and-text.html isn't on the 
Skipped list, it caused assertion only on the debug bot.
Comment 7 Csaba Osztrogonác 2011-02-09 03:21:24 PST
Landed in http://trac.webkit.org/changeset/78038 .

Thanks for the quick fix.