Bug 53881

Summary: [WIN] Add missing includes and forward declarations for DownloadBundle
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch
none
Patch none

Patrick R. Gansterer
Reported 2011-02-06 11:30:25 PST
see patch
Attachments
Patch (2.49 KB, patch)
2011-02-06 11:32 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (2.49 KB, patch)
2011-02-06 14:35 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-02-06 11:32:42 PST
Created attachment 81417 [details] Patch
Patrick R. Gansterer
Comment 2 2011-02-06 14:35:13 PST
Created attachment 81428 [details] Patch
Adam Roben (:aroben)
Comment 3 2011-02-07 07:38:28 PST
Comment on attachment 81428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81428&action=review > Source/WebCore/platform/network/cf/DownloadBundle.h:31 > +typedef const struct __CFData* CFDataRef; Why is this needed? On Windows we pull in CoreFoundation.h through our prefix header. > Source/WebCore/platform/network/win/DownloadBundleWin.cpp:29 > +#include <CoreFoundation/CoreFoundation.h> Same question. > Source/WebCore/platform/network/win/DownloadBundleWin.cpp:32 > +#include <sys/stat.h> > +#include <sys/types.h> Presumably these are getting pulled in through the prefix header on Windows, too.
WebKit Commit Bot
Comment 4 2011-02-08 08:50:28 PST
Comment on attachment 81428 [details] Patch Clearing flags on attachment: 81428 Committed r77944: <http://trac.webkit.org/changeset/77944>
WebKit Commit Bot
Comment 5 2011-02-08 08:50:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.