| Summary: | [WIN] Add missing includes and forward declarations for DownloadBundle | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||
| Component: | Platform | Assignee: | Patrick R. Gansterer <paroga> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aroben, commit-queue | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Attachments: |
|
||||||||
|
Description
Patrick R. Gansterer
2011-02-06 11:30:25 PST
Created attachment 81417 [details]
Patch
Created attachment 81428 [details]
Patch
Comment on attachment 81428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81428&action=review > Source/WebCore/platform/network/cf/DownloadBundle.h:31 > +typedef const struct __CFData* CFDataRef; Why is this needed? On Windows we pull in CoreFoundation.h through our prefix header. > Source/WebCore/platform/network/win/DownloadBundleWin.cpp:29 > +#include <CoreFoundation/CoreFoundation.h> Same question. > Source/WebCore/platform/network/win/DownloadBundleWin.cpp:32 > +#include <sys/stat.h> > +#include <sys/types.h> Presumably these are getting pulled in through the prefix header on Windows, too. Comment on attachment 81428 [details] Patch Clearing flags on attachment: 81428 Committed r77944: <http://trac.webkit.org/changeset/77944> All reviewed patches have been landed. Closing bug. |