Bug 53874

Summary:

[Qt] Clear page's groupName even when not in DRT

Product:

WebKit

Reporter:

Robert Hogan <robert>

Component:

New Bugs

Assignee:

Robert Hogan <robert>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	kling: review+, kling: commit-queue-

Description Robert Hogan 2011-02-06 08:07:29 PST

[Qt] Clear page's groupName even when not in DRT

Comment 1 Robert Hogan 2011-02-06 08:09:00 PST

Created attachment 81405 [details]
Patch

Comment 2 Andreas Kling 2011-02-06 08:37:35 PST

Comment on attachment 81405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81405&action=review

r=me

> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:310
> +    m_webPage->d->page->setGroupName(QString());

Use String() instead of QString() here to avoid the extra implicit conversion.

Comment 3 Robert Hogan 2011-02-06 10:19:30 PST

Committed r77772: <http://trac.webkit.org/changeset/77772>

Comment 4 WebKit Review Bot 2011-02-06 10:46:48 PST

http://trac.webkit.org/changeset/77772 might have broken Qt Linux Release
The following tests are not passing:
http/tests/websocket/tests/websocket-pending-activity.html