Bug 53874

Summary: [Qt] Clear page's groupName even when not in DRT
Product: WebKit Reporter: Robert Hogan <robert>
Component: New BugsAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch kling: review+, kling: commit-queue-

Robert Hogan
Reported 2011-02-06 08:07:29 PST
[Qt] Clear page's groupName even when not in DRT
Attachments
Patch (2.61 KB, patch)
2011-02-06 08:09 PST, Robert Hogan 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2011-02-06 08:09:00 PST
Created attachment 81405 [details] Patch
Andreas Kling
Comment 2 2011-02-06 08:37:35 PST
Comment on attachment 81405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81405&action=review r=me > Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:310 > + m_webPage->d->page->setGroupName(QString()); Use String() instead of QString() here to avoid the extra implicit conversion.
Robert Hogan
Comment 3 2011-02-06 10:19:30 PST
Committed r77772: <http://trac.webkit.org/changeset/77772>
WebKit Review Bot
Comment 4 2011-02-06 10:46:48 PST
http://trac.webkit.org/changeset/77772 might have broken Qt Linux Release The following tests are not passing: http/tests/websocket/tests/websocket-pending-activity.html
Note You need to log in before you can comment on or make changes to this bug.