Bug 53866

Summary: [chromium] Remove unused "external" case from PopupMenuChromium
Product: WebKit Reporter: Jay Civelli <jcivelli>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jay Civelli
Reported 2011-02-05 23:34:59 PST
In the PopupMenuChromium.[h,cpp] files, we still have the code for the "external" case, which was used previously on the Mac. That code is not used anymore (see https://bugs.webkit.org/show_bug.cgi?id=46016) and should be removed.
Attachments
Patch (4.38 KB, patch)
2011-02-05 23:43 PST, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.38 KB, patch)
2011-02-07 13:01 PST, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jay Civelli
Comment 1 2011-02-05 23:43:36 PST
Created attachment 81392 [details] Patch
Jay Civelli
Comment 2 2011-02-07 13:01:33 PST
Created attachment 81510 [details] Patch for landing
WebKit Commit Bot
Comment 3 2011-02-07 22:46:03 PST
Comment on attachment 81510 [details] Patch for landing Clearing flags on attachment: 81510 Committed r77904: <http://trac.webkit.org/changeset/77904>
WebKit Commit Bot
Comment 4 2011-02-07 22:46:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.